fix daemon HyperFrames scaffold and runtime - #7030
Conversation
🚀 Landing page previewThis PR is deployed to a Cloudflare Pages preview — not staging or production:
|
…-runtime # Conflicts: # apps/daemon/src/server.ts # apps/daemon/tests/prompts/__snapshots__/system-prompt-matrix.test.ts.snap # design-templates/hyperframes/references/html-in-canvas.md # plugins/_official/examples/hyperframes/references/html-in-canvas.md
|
Quick heads-up: this PR touches user-visible daemon/CLI runtime behavior, so it will need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready. Also, could you update the PR body's Surface area checklist? The rest of the write-up is clear, but that section should reflect the CLI/API/extension-point/default-behavior changes called out elsewhere in the description. |
1 similar comment
|
Quick heads-up: this PR touches user-visible daemon/CLI runtime behavior, so it will need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready. Also, could you update the PR body's Surface area checklist? The rest of the write-up is clear, but that section should reflect the CLI/API/extension-point/default-behavior changes called out elsewhere in the description. |
|
@Siri-Ray I'm holding off on generating review comments for #7030 because this pull request has merge conflicts right now. Please resolve the conflicts with main and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look. 🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos. |
Generated-By: looper 0.11.8 (runner=fixer, agent=codex)
|
@Siri-Ray I'm holding off on generating review comments for #7030 because this pull request has merge conflicts right now. Please resolve the conflicts with main and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look. 🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos. |
Generated-By: looper 0.11.8 (runner=fixer, agent=codex)
AmyShang-alt
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I completed packaged-runtime QA for this PR. I am requesting changes because the final macOS arm64 app cannot load the bundled HyperFrames CLI; the inline comment includes the isolated-package reproduction and required follow-up.
|
Hey @Siri-Ray — packaged-runtime QA has now identified the current blocker on this head: the bundled HyperFrames CLI is still missing its native The concrete repro and expected follow-up are already captured in @AmyShang-alt's blocking review comment above, so the next step is to fix that packaged payload path and push an updated head for QA to re-run. 💡 To drive this PR to merge hands-free, paste this to your AI coding agent (Claude Code / Codex / opencode / Cursor …): |
Copy the target-native sharp closure into final standalone payloads and execute the packaged HyperFrames CLI during afterPack. Generated-By: looper 0.11.8 (runner=fixer, agent=codex)
|
Looper fixer round complete — c1ea0fb
🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos. |
Only chmod the copied fallback so a successful hard link does not try to change the CI-owned Node inode. Generated-By: looper 0.11.8 (runner=fixer, agent=codex)
There was a problem hiding this comment.
QA accepted on head e909342.
The previous packaged-runtime blocker is resolved:
- The final macOS app contains sharp and its Darwin ARM64/libvips native runtime closure.
- The packaged HyperFrames CLI reports 0.8.1 and passes lint in an isolated environment without ambient npx.
- A real packaged render completed successfully (H.264, 1920x1080, 1 second).
- Focused tools-pack tests: 39 passed.
- Focused daemon/HyperFrames tests: 8 passed.
- Required GitHub checks are green, including Windows tools-pack payload coverage.
Residual sampling recommendation: run one full installed-package render on Windows before release. This is non-blocking for this PR.
The reported packaged sharp dependency blocker was fixed on head e909342 and revalidated with a real isolated packaged render. Superseded by QA approval review #4968060456.
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7030-to-release/v0.20.0
git worktree add --checkout .worktree/backport-7030-to-release/v0.20.0 backport-7030-to-release/v0.20.0
cd .worktree/backport-7030-to-release/v0.20.0
git reset --hard HEAD^
git cherry-pick -x 0d53c96bebb6caa4e23fdcc0f1c256b7f26e033c
git push --force-with-lease |













































Why
HyperFrames creation could fail before
hyperframes.jsonexisted because both project setup and rendering delegated runtime selection to an ambientnpxinstallation. On Apple Silicon, a stale or incompatible nativesharpartifact in the user npm cache caused initialization to exit early; the daemon then correctly rejected the directory as an incomplete HyperFrames project.The author use case is making in-app HyperFrames generation reliable in development and packaged builds without depending on a user's npm cache, global skill installation, or PATH-selected CLI.
What users will see
npx..hyperframes-cache; the final MP4 remains the only project-root deliverable.od media scaffold --json.Surface area
Screenshots
Not applicable — this PR does not change the UI.
Bug fix verification
spawn npx ENOENTwhen no ambientnpxwas available, proving rendering still depended on external CLI resolution.apps/daemon/tests/media/hyperframes.test.tsnow verifies the pinned Node/CLI invocation withoutnpx.Validation
pnpm install --frozen-lockfilepnpm guardpnpm typecheck